From 2de47f26cec0739e50e00675c5e898e0612c98c5 Mon Sep 17 00:00:00 2001
From: Joseph Baxter <joseph.baxter@nottingham.ac.uk>
Date: Fri, 23 May 2014 15:43:18 +0100
Subject: [PATCH] tidy up

---
 export.php | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/export.php b/export.php
index ad6bcf0..fab396f 100644
--- a/export.php
+++ b/export.php
@@ -87,15 +87,14 @@ if ($mform->is_submitted()) {
         if (isset($formdata->ident['uname'])) {
             $data->tabhead[] = get_string('username');
         }
-        if (isset($formdata->ident['idnumber'])) {
-            $data->tabhead[] = get_string('idnumber');
-        }
-        if (isset($formdata->ident['institution'])) {
-            $data->tabhead[] = get_string('institution');
-        }
-        if (isset($formdata->ident['department'])) {
-            $data->tabhead[] = get_string('department');
+        
+        $optional = array('idnumber', 'institution', 'department');
+        foreach ($optional as $opt) {
+            if (isset($formdata->ident[$opt])) {
+                $data->tabhead[] = get_string($opt);
+            }
         }
+        
         $data->tabhead[] = get_string('lastname');
         $data->tabhead[] = get_string('firstname');
 
@@ -122,15 +121,14 @@ if ($mform->is_submitted()) {
             if (isset($formdata->ident['uname'])) {
                 $data->table[$i][] = $user->username;
             }
-            if (isset($formdata->ident['idnumber'])) {
-                $data->table[$i][] = $user->idnumber;
-            }
-            if (isset($formdata->ident['institution'])) {
-                $data->table[$i][] = $user->institution;
-            }
-            if (isset($formdata->ident['department'])) {
-                $data->table[$i][] = $user->department;
+            
+            $optional_row = array('idnumber', 'institution', 'department');
+            foreach ($$optional_row as $opt) {
+                if (isset($formdata->ident[$opt])) {
+                    $data->table[$i][] = $user->$opt;
+                }
             }
+            
             $data->table[$i][] = $user->lastname;
             $data->table[$i][] = $user->firstname;
             $cellsgenerator = new user_sessions_cells_text_generator($reportdata, $user);