ILB
/
moodle-mod_attendance
9
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Browse Source

Fix up auto-marking code.

40-behatfixes
Dan Marsden 3 years ago
parent
9e3d486020
commit
967633cdc1
1 changed files with 12 additions and 17 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 29
      classes/task/auto_mark.php

29
classes/task/auto_mark.php
View File

@ -144,8 +144,6 @@ class auto_mark extends \core\task\scheduled_task {
$logusers->close(); $logusers->close();
} else if ($session->automark == 3) { } else if ($session->automark == 3) {
$completedusers = array();
$newlog = new \stdClass(); $newlog = new \stdClass();
$newlog->timetaken = $now; $newlog->timetaken = $now;
$newlog->takenby = 0; $newlog->takenby = 0;
@ -154,22 +152,19 @@ class auto_mark extends \core\task\scheduled_task {
$newlog->statusset = implode(',', array_keys( (array)$att->get_statuses())); $newlog->statusset = implode(',', array_keys( (array)$att->get_statuses()));
// Get users who have completed the course in this session. // Get users who have completed the course in this session.
$completedusers[] = $DB->get_record('course_modules_completion', array( $completedusers = $DB->get_records_select('course_modules_completion',
'coursemoduleid' => $session->automarkcmid, 'coursemoduleid = ? AND completionstate > 0', [$session->automarkcmid]);
'completionstate' => 1
));
if (!empty($completedusers)) {
// Get automark status the users and update the attendance log.
foreach ($completedusers as $completionuser) {
$newlog->statusid = $att->get_automark_status($completionuser->timemodified, $session->id); // Get automark status the users and update the attendance log.
foreach ($completedusers as $completionuser) {
if (!empty($newlog->statusid)) { if (empty($completionuser->timemodified) || (empty($completionuser->userid))) {
$newlog->studentid = $completionuser->userid; // Time modified or userid not set - we can't calculate for this record.
$DB->insert_record('attendance_log', $newlog); continue;
} }
$newlog->studentid = $completionuser->userid;
$newlog->statusid = $att->get_automark_status($completionuser->timemodified, $session->id);
if (!empty($newlog->statusid)) {
$DB->insert_record('attendance_log', $newlog);
} }
} }
} }

Write Preview
Loading…
Cancel
Save