From f34760ca1798f1e091def02169e566bba86740bc Mon Sep 17 00:00:00 2001 From: Dan Marsden Date: Thu, 18 May 2017 12:55:26 +1200 Subject: [PATCH] Fix some coding guideline issues. --- calendar.js | 1 + locallib.php | 4 +++- student_attendance_form.php | 8 ++++++++ .../moodle-mod_attendance-groupfilter-debug.js | 2 +- .../moodle-mod_attendance-groupfilter.js | 2 +- yui/src/groupfilter/js/groupfilter.js | 2 +- 6 files changed, 15 insertions(+), 4 deletions(-) diff --git a/calendar.js b/calendar.js index 284ebe0..63cc7e4 100644 --- a/calendar.js +++ b/calendar.js @@ -64,6 +64,7 @@ YUI().use('yui2-container', 'yui2-calendar', function(Y) { calendar = new YAHOO.widget.Calendar("cal", { iframe: false, // Turn iframe off, since container has iframe support. + // eslint-disable-next-line camelcase hide_blank_weeks: true // Enable, to demonstrate how we handle changing height, using changeContent. }); diff --git a/locallib.php b/locallib.php index b6eb971..57866fa 100644 --- a/locallib.php +++ b/locallib.php @@ -327,9 +327,11 @@ function attendance_remove_status($status, $context = null, $cm = null) { * @param bool $visible * @param stdClass $context * @param stdClass $cm + * @param int $studentavailability * @return array */ -function attendance_update_status($status, $acronym, $description, $grade, $visible, $context = null, $cm = null, $studentavailability = null) { +function attendance_update_status($status, $acronym, $description, $grade, $visible, + $context = null, $cm = null, $studentavailability = null) { global $DB; if (empty($context)) { diff --git a/student_attendance_form.php b/student_attendance_form.php index dd1f928..e0ef517 100644 --- a/student_attendance_form.php +++ b/student_attendance_form.php @@ -97,6 +97,14 @@ class mod_attendance_student_attendance_form extends moodleform { $mform->addRule('statusarray', get_string('attendancenotset', 'attendance'), 'required', '', 'client', false, false); $this->add_action_buttons(); } + + /** + * Validate Form. + * + * @param array $data + * @param array $files + * @return array + */ public function validation($data, $files) { $errors = array(); // Check if this status is allowed to be set. diff --git a/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js b/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js index 13c2421..6bb50aa 100644 --- a/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js +++ b/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js @@ -16,7 +16,7 @@ M.mod_attendance.groupfilter = { /** * Update the user list with those found in the selected group. */ - update_user_list: function() { + update_user_list: function() { // eslint-disable-line camelcase "use strict"; var groupid, userlist, users, userid, opt; diff --git a/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js b/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js index 13c2421..6bb50aa 100644 --- a/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js +++ b/yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js @@ -16,7 +16,7 @@ M.mod_attendance.groupfilter = { /** * Update the user list with those found in the selected group. */ - update_user_list: function() { + update_user_list: function() { // eslint-disable-line camelcase "use strict"; var groupid, userlist, users, userid, opt; diff --git a/yui/src/groupfilter/js/groupfilter.js b/yui/src/groupfilter/js/groupfilter.js index 6ad931a..5cd7ade 100644 --- a/yui/src/groupfilter/js/groupfilter.js +++ b/yui/src/groupfilter/js/groupfilter.js @@ -14,7 +14,7 @@ M.mod_attendance.groupfilter = { /** * Update the user list with those found in the selected group. */ - update_user_list: function() { + update_user_list: function() { // eslint-disable-line camelcase "use strict"; var groupid, userlist, users, userid, opt;