diff --git a/CHANGES.md b/CHANGES.md index 15f6f86..6b6d1c0 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,7 +1,8 @@ Changes in version 3.36.31.1 (2015123101) ------------------------------------------------------------------ -- New: Disable summarize of attempts +- New: Disable summarize of attempts. +- CONTRIB-5605: Quotation marks breaks the js-code in game Cryptex. Changes in version 3.36.29.1 (2015122901) ------------------------------------------------------------------ -- Fix: Coding style +- Fixing coding style. diff --git a/cryptex/play.php b/cryptex/play.php index d425e88..1c601ef 100755 --- a/cryptex/play.php +++ b/cryptex/play.php @@ -325,10 +325,11 @@ width: 240pt; $question = game_show_query( $game, $q, "$i. ".$q->questiontext, $context); $question2 = strip_tags($question); // ADDED BY DP (AUG 2009) - fixes " breaking the Answer button for this question. + echo ''; if (($onlyshow == false) and ($showsolution == false)) { if (($game->param8 == 0) || ($game->param8 > $q->tries)) { $question .= '  '; + get_string( 'answer').'" onclick="OnCheck( '.$q->id.',msg);" />'; } } echo $question; diff --git a/db/upgrade.php b/db/upgrade.php index a08108b..ebaae23 100755 --- a/db/upgrade.php +++ b/db/upgrade.php @@ -1525,7 +1525,7 @@ function xmldb_game_upgrade($oldversion) { upgrade_mod_savepoint(true, 2015122105, 'game'); } - if ($oldversion < ($ver = 2015123101)) { + if ($oldversion < ($ver = 2015123101)) { $table = new xmldb_table('game'); $field = new xmldb_field('disablesummarize', XMLDB_TYPE_INTEGER, '1', XMLDB_UNSIGNED, null, null, '0'); if (!$dbman->field_exists($table, $field)) { diff --git a/view.php b/view.php index 3ec778a..13229d0 100755 --- a/view.php +++ b/view.php @@ -72,7 +72,7 @@ if (game_use_events()) { $completion = new completion_info($course); $completion->set_module_viewed($cm); -// Here have to check if not need summarize +// Here have to check if not need summarize. if ($game->disablesummarize) { if (game_can_start_new_attempt( $game)) { require_once( 'attempt.php');