You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
520 lines
22 KiB
520 lines
22 KiB
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* Forum search unit tests.
|
|
*
|
|
* @package mod_forum
|
|
* @category test
|
|
* @copyright 2015 David Monllao {@link http://www.davidmonllao.com}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
global $CFG;
|
|
require_once($CFG->dirroot . '/search/tests/fixtures/testable_core_search.php');
|
|
require_once($CFG->dirroot . '/mod/forum/tests/generator/lib.php');
|
|
require_once($CFG->dirroot . '/mod/forum/lib.php');
|
|
|
|
/**
|
|
* Provides the unit tests for forum search.
|
|
*
|
|
* @package mod_forum
|
|
* @category test
|
|
* @copyright 2015 David Monllao {@link http://www.davidmonllao.com}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class mod_forum_search_testcase extends advanced_testcase {
|
|
|
|
/**
|
|
* @var string Area id
|
|
*/
|
|
protected $forumpostareaid = null;
|
|
|
|
public function setUp() {
|
|
$this->resetAfterTest(true);
|
|
set_config('enableglobalsearch', true);
|
|
|
|
$this->forumpostareaid = \core_search\manager::generate_areaid('mod_forum', 'post');
|
|
|
|
// Set \core_search::instance to the mock_search_engine as we don't require the search engine to be working to test this.
|
|
$search = testable_core_search::instance();
|
|
}
|
|
|
|
/**
|
|
* Availability.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function test_search_enabled() {
|
|
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
list($componentname, $varname) = $searcharea->get_config_var_name();
|
|
|
|
// Enabled by default once global search is enabled.
|
|
$this->assertTrue($searcharea->is_enabled());
|
|
|
|
set_config($varname . '_enabled', 0, $componentname);
|
|
$this->assertFalse($searcharea->is_enabled());
|
|
|
|
set_config($varname . '_enabled', 1, $componentname);
|
|
$this->assertTrue($searcharea->is_enabled());
|
|
}
|
|
|
|
/**
|
|
* Indexing mod forum contents.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function test_posts_indexing() {
|
|
global $DB;
|
|
|
|
// Returns the instance as long as the area is supported.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$this->assertInstanceOf('\mod_forum\search\post', $searcharea);
|
|
|
|
$user1 = self::getDataGenerator()->create_user();
|
|
$user2 = self::getDataGenerator()->create_user();
|
|
|
|
$course1 = self::getDataGenerator()->create_course();
|
|
$course2 = self::getDataGenerator()->create_course();
|
|
|
|
$this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'student');
|
|
$this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
|
|
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
|
|
// Available for both student and teacher.
|
|
$forum1 = self::getDataGenerator()->create_module('forum', $record);
|
|
|
|
// Create discussion1.
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user1->id;
|
|
$record->forum = $forum1->id;
|
|
$record->message = 'discussion';
|
|
$discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Create post1 in discussion1.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion1->id;
|
|
$record->parent = $discussion1->firstpost;
|
|
$record->userid = $user2->id;
|
|
$record->message = 'post2';
|
|
$discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
// All records.
|
|
$recordset = $searcharea->get_recordset_by_timestamp(0);
|
|
$this->assertTrue($recordset->valid());
|
|
$nrecords = 0;
|
|
foreach ($recordset as $record) {
|
|
$this->assertInstanceOf('stdClass', $record);
|
|
$doc = $searcharea->get_document($record);
|
|
$this->assertInstanceOf('\core_search\document', $doc);
|
|
|
|
// Static caches are working.
|
|
$dbreads = $DB->perf_get_reads();
|
|
$doc = $searcharea->get_document($record);
|
|
$this->assertEquals($dbreads, $DB->perf_get_reads());
|
|
$this->assertInstanceOf('\core_search\document', $doc);
|
|
$nrecords++;
|
|
}
|
|
// If there would be an error/failure in the foreach above the recordset would be closed on shutdown.
|
|
$recordset->close();
|
|
$this->assertEquals(2, $nrecords);
|
|
|
|
// The +2 is to prevent race conditions.
|
|
$recordset = $searcharea->get_recordset_by_timestamp(time() + 2);
|
|
|
|
// No new records.
|
|
$this->assertFalse($recordset->valid());
|
|
$recordset->close();
|
|
|
|
// Context test: create another forum with 1 post.
|
|
$forum2 = self::getDataGenerator()->create_module('forum', ['course' => $course1->id]);
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user1->id;
|
|
$record->forum = $forum2->id;
|
|
$record->message = 'discussion';
|
|
self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Test indexing with each forum then combined course context.
|
|
$rs = $searcharea->get_document_recordset(0, context_module::instance($forum1->cmid));
|
|
$this->assertEquals(2, iterator_count($rs));
|
|
$rs->close();
|
|
$rs = $searcharea->get_document_recordset(0, context_module::instance($forum2->cmid));
|
|
$this->assertEquals(1, iterator_count($rs));
|
|
$rs->close();
|
|
$rs = $searcharea->get_document_recordset(0, context_course::instance($course1->id));
|
|
$this->assertEquals(3, iterator_count($rs));
|
|
$rs->close();
|
|
}
|
|
|
|
/**
|
|
* Document contents.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function test_posts_document() {
|
|
global $DB;
|
|
|
|
// Returns the instance as long as the area is supported.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$this->assertInstanceOf('\mod_forum\search\post', $searcharea);
|
|
|
|
$user = self::getDataGenerator()->create_user();
|
|
$course1 = self::getDataGenerator()->create_course();
|
|
$this->getDataGenerator()->enrol_user($user->id, $course1->id, 'teacher');
|
|
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$forum1 = self::getDataGenerator()->create_module('forum', $record);
|
|
|
|
// Teacher only.
|
|
$forum2 = self::getDataGenerator()->create_module('forum', $record);
|
|
set_coursemodule_visible($forum2->cmid, 0);
|
|
|
|
// Create discussion1.
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user->id;
|
|
$record->forum = $forum1->id;
|
|
$record->message = 'discussion';
|
|
$record->groupid = 0;
|
|
$discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Create post1 in discussion1.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion1->id;
|
|
$record->parent = $discussion1->firstpost;
|
|
$record->userid = $user->id;
|
|
$record->subject = 'subject1';
|
|
$record->message = 'post1';
|
|
$record->groupid = -1;
|
|
$discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
$post1 = $DB->get_record('forum_posts', array('id' => $discussion1reply1->id));
|
|
$post1->forumid = $forum1->id;
|
|
$post1->courseid = $forum1->course;
|
|
$post1->groupid = -1;
|
|
|
|
$doc = $searcharea->get_document($post1);
|
|
$this->assertInstanceOf('\core_search\document', $doc);
|
|
$this->assertEquals($discussion1reply1->id, $doc->get('itemid'));
|
|
$this->assertEquals($this->forumpostareaid . '-' . $discussion1reply1->id, $doc->get('id'));
|
|
$this->assertEquals($course1->id, $doc->get('courseid'));
|
|
$this->assertEquals($user->id, $doc->get('userid'));
|
|
$this->assertEquals($discussion1reply1->subject, $doc->get('title'));
|
|
$this->assertEquals($discussion1reply1->message, $doc->get('content'));
|
|
}
|
|
|
|
/**
|
|
* Group support for forum posts.
|
|
*/
|
|
public function test_posts_group_support() {
|
|
// Get the search area and test generators.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$generator = $this->getDataGenerator();
|
|
$forumgenerator = $generator->get_plugin_generator('mod_forum');
|
|
|
|
// Create a course, a user, and two groups.
|
|
$course = $generator->create_course();
|
|
$user = $generator->create_user();
|
|
$generator->enrol_user($user->id, $course->id, 'teacher');
|
|
$group1 = $generator->create_group(['courseid' => $course->id]);
|
|
$group2 = $generator->create_group(['courseid' => $course->id]);
|
|
|
|
// Separate groups forum.
|
|
$forum = self::getDataGenerator()->create_module('forum', ['course' => $course->id,
|
|
'groupmode' => SEPARATEGROUPS]);
|
|
|
|
// Create discussion with each group and one for all groups. One has a post in.
|
|
$discussion1 = $forumgenerator->create_discussion(['course' => $course->id,
|
|
'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd1',
|
|
'groupid' => $group1->id]);
|
|
$forumgenerator->create_discussion(['course' => $course->id,
|
|
'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd2',
|
|
'groupid' => $group2->id]);
|
|
$forumgenerator->create_discussion(['course' => $course->id,
|
|
'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd3']);
|
|
|
|
// Create a reply in discussion1.
|
|
$forumgenerator->create_post(['discussion' => $discussion1->id, 'parent' => $discussion1->firstpost,
|
|
'userid' => $user->id, 'message' => 'p1']);
|
|
|
|
// Do the indexing of all 4 posts.
|
|
$rs = $searcharea->get_recordset_by_timestamp(0);
|
|
$results = [];
|
|
foreach ($rs as $rec) {
|
|
$results[$rec->message] = $rec;
|
|
}
|
|
$rs->close();
|
|
$this->assertCount(4, $results);
|
|
|
|
// Check each document has the correct groupid.
|
|
$doc = $searcharea->get_document($results['d1']);
|
|
$this->assertTrue($doc->is_set('groupid'));
|
|
$this->assertEquals($group1->id, $doc->get('groupid'));
|
|
$doc = $searcharea->get_document($results['d2']);
|
|
$this->assertTrue($doc->is_set('groupid'));
|
|
$this->assertEquals($group2->id, $doc->get('groupid'));
|
|
$doc = $searcharea->get_document($results['d3']);
|
|
$this->assertFalse($doc->is_set('groupid'));
|
|
$doc = $searcharea->get_document($results['p1']);
|
|
$this->assertTrue($doc->is_set('groupid'));
|
|
$this->assertEquals($group1->id, $doc->get('groupid'));
|
|
|
|
// While we're here, also test that the search area requests restriction by group.
|
|
$modinfo = get_fast_modinfo($course);
|
|
$this->assertTrue($searcharea->restrict_cm_access_by_group($modinfo->get_cm($forum->cmid)));
|
|
|
|
// In visible groups mode, it won't request restriction by group.
|
|
set_coursemodule_groupmode($forum->cmid, VISIBLEGROUPS);
|
|
$modinfo = get_fast_modinfo($course);
|
|
$this->assertFalse($searcharea->restrict_cm_access_by_group($modinfo->get_cm($forum->cmid)));
|
|
}
|
|
|
|
/**
|
|
* Document accesses.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function test_posts_access() {
|
|
global $DB;
|
|
|
|
// Returns the instance as long as the area is supported.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
|
|
$user1 = self::getDataGenerator()->create_user();
|
|
$user2 = self::getDataGenerator()->create_user();
|
|
|
|
$course1 = self::getDataGenerator()->create_course();
|
|
$course2 = self::getDataGenerator()->create_course();
|
|
|
|
$this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'teacher');
|
|
$this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
|
|
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
|
|
// Available for both student and teacher.
|
|
$forum1 = self::getDataGenerator()->create_module('forum', $record);
|
|
|
|
// Teacher only.
|
|
$forum2 = self::getDataGenerator()->create_module('forum', $record);
|
|
set_coursemodule_visible($forum2->cmid, 0);
|
|
|
|
// Create discussion1.
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user1->id;
|
|
$record->forum = $forum1->id;
|
|
$record->message = 'discussion';
|
|
$discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Create post1 in discussion1.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion1->id;
|
|
$record->parent = $discussion1->firstpost;
|
|
$record->userid = $user2->id;
|
|
$record->message = 'post1';
|
|
$discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
// Create discussion2 only visible to teacher.
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user1->id;
|
|
$record->forum = $forum2->id;
|
|
$record->message = 'discussion';
|
|
$discussion2 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Create post2 in discussion2.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion2->id;
|
|
$record->parent = $discussion2->firstpost;
|
|
$record->userid = $user1->id;
|
|
$record->message = 'post2';
|
|
$discussion2reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
$this->setUser($user2);
|
|
$this->assertEquals(\core_search\manager::ACCESS_GRANTED, $searcharea->check_access($discussion1reply1->id));
|
|
$this->assertEquals(\core_search\manager::ACCESS_DENIED, $searcharea->check_access($discussion2reply1->id));
|
|
}
|
|
|
|
/**
|
|
* Test for post attachments.
|
|
*
|
|
* @return void
|
|
*/
|
|
public function test_attach_files() {
|
|
global $DB;
|
|
|
|
$fs = get_file_storage();
|
|
|
|
// Returns the instance as long as the area is supported.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$this->assertInstanceOf('\mod_forum\search\post', $searcharea);
|
|
|
|
$user1 = self::getDataGenerator()->create_user();
|
|
$user2 = self::getDataGenerator()->create_user();
|
|
|
|
$course1 = self::getDataGenerator()->create_course();
|
|
|
|
$this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'student');
|
|
$this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
|
|
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
|
|
$forum1 = self::getDataGenerator()->create_module('forum', $record);
|
|
|
|
// Create discussion1.
|
|
$record = new stdClass();
|
|
$record->course = $course1->id;
|
|
$record->userid = $user1->id;
|
|
$record->forum = $forum1->id;
|
|
$record->message = 'discussion';
|
|
$record->attachemt = 1;
|
|
$discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
|
|
|
|
// Attach 2 file to the discussion post.
|
|
$post = $DB->get_record('forum_posts', array('discussion' => $discussion1->id));
|
|
$filerecord = array(
|
|
'contextid' => context_module::instance($forum1->cmid)->id,
|
|
'component' => 'mod_forum',
|
|
'filearea' => 'attachment',
|
|
'itemid' => $post->id,
|
|
'filepath' => '/',
|
|
'filename' => 'myfile1'
|
|
);
|
|
$file1 = $fs->create_file_from_string($filerecord, 'Some contents 1');
|
|
$filerecord['filename'] = 'myfile2';
|
|
$file2 = $fs->create_file_from_string($filerecord, 'Some contents 2');
|
|
|
|
// Create post1 in discussion1.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion1->id;
|
|
$record->parent = $discussion1->firstpost;
|
|
$record->userid = $user2->id;
|
|
$record->message = 'post2';
|
|
$record->attachemt = 1;
|
|
$discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
$filerecord['itemid'] = $discussion1reply1->id;
|
|
$filerecord['filename'] = 'myfile3';
|
|
$file3 = $fs->create_file_from_string($filerecord, 'Some contents 3');
|
|
|
|
// Create post2 in discussion1.
|
|
$record = new stdClass();
|
|
$record->discussion = $discussion1->id;
|
|
$record->parent = $discussion1->firstpost;
|
|
$record->userid = $user2->id;
|
|
$record->message = 'post3';
|
|
$discussion1reply2 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
|
|
|
|
// Now get all the posts and see if they have the right files attached.
|
|
$searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$recordset = $searcharea->get_recordset_by_timestamp(0);
|
|
$nrecords = 0;
|
|
foreach ($recordset as $record) {
|
|
$doc = $searcharea->get_document($record);
|
|
$searcharea->attach_files($doc);
|
|
$files = $doc->get_files();
|
|
// Now check that each doc has the right files on it.
|
|
switch ($doc->get('itemid')) {
|
|
case ($post->id):
|
|
$this->assertCount(2, $files);
|
|
$this->assertEquals($file1->get_id(), $files[$file1->get_id()]->get_id());
|
|
$this->assertEquals($file2->get_id(), $files[$file2->get_id()]->get_id());
|
|
break;
|
|
case ($discussion1reply1->id):
|
|
$this->assertCount(1, $files);
|
|
$this->assertEquals($file3->get_id(), $files[$file3->get_id()]->get_id());
|
|
break;
|
|
case ($discussion1reply2->id):
|
|
$this->assertCount(0, $files);
|
|
break;
|
|
default:
|
|
$this->fail('Unexpected post returned');
|
|
break;
|
|
}
|
|
$nrecords++;
|
|
}
|
|
$recordset->close();
|
|
$this->assertEquals(3, $nrecords);
|
|
}
|
|
|
|
/**
|
|
* Tests that reindexing works in order starting from the forum with most recent discussion.
|
|
*/
|
|
public function test_posts_get_contexts_to_reindex() {
|
|
global $DB;
|
|
|
|
$generator = $this->getDataGenerator();
|
|
$adminuser = get_admin();
|
|
|
|
$course1 = $generator->create_course();
|
|
$course2 = $generator->create_course();
|
|
|
|
$time = time() - 1000;
|
|
|
|
// Create 3 forums (two in course 1, one in course 2 - doesn't make a difference).
|
|
$forum1 = $generator->create_module('forum', ['course' => $course1->id]);
|
|
$forum2 = $generator->create_module('forum', ['course' => $course1->id]);
|
|
$forum3 = $generator->create_module('forum', ['course' => $course2->id]);
|
|
$forum4 = $generator->create_module('forum', ['course' => $course2->id]);
|
|
|
|
// Hack added time for the course_modules entries. These should not be used (they would
|
|
// be used by the base class implementation). We are setting this so that the order would
|
|
// be 4, 3, 2, 1 if this ordering were used (newest first).
|
|
$DB->set_field('course_modules', 'added', $time + 100, ['id' => $forum1->cmid]);
|
|
$DB->set_field('course_modules', 'added', $time + 110, ['id' => $forum2->cmid]);
|
|
$DB->set_field('course_modules', 'added', $time + 120, ['id' => $forum3->cmid]);
|
|
$DB->set_field('course_modules', 'added', $time + 130, ['id' => $forum4->cmid]);
|
|
|
|
$forumgenerator = $generator->get_plugin_generator('mod_forum');
|
|
|
|
// Create one discussion in forums 1 and 3, three in forum 2, and none in forum 4.
|
|
$forumgenerator->create_discussion(['course' => $course1->id,
|
|
'forum' => $forum1->id, 'userid' => $adminuser->id, 'timemodified' => $time + 20]);
|
|
|
|
$forumgenerator->create_discussion(['course' => $course1->id,
|
|
'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 10]);
|
|
$forumgenerator->create_discussion(['course' => $course1->id,
|
|
'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 30]);
|
|
$forumgenerator->create_discussion(['course' => $course1->id,
|
|
'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 11]);
|
|
|
|
$forumgenerator->create_discussion(['course' => $course2->id,
|
|
'forum' => $forum3->id, 'userid' => $adminuser->id, 'timemodified' => $time + 25]);
|
|
|
|
// Get the contexts in reindex order.
|
|
$area = \core_search\manager::get_search_area($this->forumpostareaid);
|
|
$contexts = iterator_to_array($area->get_contexts_to_reindex(), false);
|
|
|
|
// We expect them in order of newest discussion. Forum 4 is not included at all (which is
|
|
// correct because it has no content).
|
|
$expected = [
|
|
\context_module::instance($forum2->cmid),
|
|
\context_module::instance($forum3->cmid),
|
|
\context_module::instance($forum1->cmid)
|
|
];
|
|
$this->assertEquals($expected, $contexts);
|
|
}
|
|
}
|
|
|