Browse Source

Fix some coding guideline issues.

MOODLE_33_STABLE
Dan Marsden 8 years ago
parent
commit
6445dbc3a1
  1. 1
      calendar.js
  2. 4
      locallib.php
  3. 8
      student_attendance_form.php
  4. 2
      yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js
  5. 2
      yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js
  6. 2
      yui/src/groupfilter/js/groupfilter.js

1
calendar.js

@ -69,6 +69,7 @@ YUI().use('yui2-container', 'yui2-calendar', function(Y) {
calendar = new YAHOO.widget.Calendar("cal", { calendar = new YAHOO.widget.Calendar("cal", {
iframe: false, // Turn iframe off, since container has iframe support. iframe: false, // Turn iframe off, since container has iframe support.
// eslint-disable-next-line camelcase
hide_blank_weeks: true // Enable, to demonstrate how we handle changing height, using changeContent. hide_blank_weeks: true // Enable, to demonstrate how we handle changing height, using changeContent.
}); });

4
locallib.php

@ -327,9 +327,11 @@ function attendance_remove_status($status, $context = null, $cm = null) {
* @param bool $visible * @param bool $visible
* @param stdClass $context * @param stdClass $context
* @param stdClass $cm * @param stdClass $cm
* @param int $studentavailability
* @return array * @return array
*/ */
function attendance_update_status($status, $acronym, $description, $grade, $visible, $context = null, $cm = null, $studentavailability = null) { function attendance_update_status($status, $acronym, $description, $grade, $visible,
$context = null, $cm = null, $studentavailability = null) {
global $DB; global $DB;
if (empty($context)) { if (empty($context)) {

8
student_attendance_form.php

@ -97,6 +97,14 @@ class mod_attendance_student_attendance_form extends moodleform {
$mform->addRule('statusarray', get_string('attendancenotset', 'attendance'), 'required', '', 'client', false, false); $mform->addRule('statusarray', get_string('attendancenotset', 'attendance'), 'required', '', 'client', false, false);
$this->add_action_buttons(); $this->add_action_buttons();
} }
/**
* Validate Form.
*
* @param array $data
* @param array $files
* @return array
*/
public function validation($data, $files) { public function validation($data, $files) {
$errors = array(); $errors = array();
// Check if this status is allowed to be set. // Check if this status is allowed to be set.

2
yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter-debug.js

@ -16,7 +16,7 @@ M.mod_attendance.groupfilter = {
/** /**
* Update the user list with those found in the selected group. * Update the user list with those found in the selected group.
*/ */
update_user_list: function() { update_user_list: function() { // eslint-disable-line camelcase
"use strict"; "use strict";
var groupid, userlist, users, userid, opt; var groupid, userlist, users, userid, opt;

2
yui/build/moodle-mod_attendance-groupfilter/moodle-mod_attendance-groupfilter.js

@ -16,7 +16,7 @@ M.mod_attendance.groupfilter = {
/** /**
* Update the user list with those found in the selected group. * Update the user list with those found in the selected group.
*/ */
update_user_list: function() { update_user_list: function() { // eslint-disable-line camelcase
"use strict"; "use strict";
var groupid, userlist, users, userid, opt; var groupid, userlist, users, userid, opt;

2
yui/src/groupfilter/js/groupfilter.js

@ -14,7 +14,7 @@ M.mod_attendance.groupfilter = {
/** /**
* Update the user list with those found in the selected group. * Update the user list with those found in the selected group.
*/ */
update_user_list: function() { update_user_list: function() { // eslint-disable-line camelcase
"use strict"; "use strict";
var groupid, userlist, users, userid, opt; var groupid, userlist, users, userid, opt;

Loading…
Cancel
Save